Patch Set 1: Code-Review-1 (1 comment)
https://gerrit.osmocom.org/#/c/4159/1/src/utils.c File src/utils.c: Line 395: const unsigned char *pos = (const unsigned char *)str; That looks weird. Why not just use "const unsigned char *str" in parameters? -- To view, visit https://gerrit.osmocom.org/4159 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idf75946eb0a84e145adad13fc7c78bb7a267aa0a Gerrit-PatchSet: 1 Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Owner: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Max <[email protected]> Gerrit-HasComments: Yes
