pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/23005 )
Change subject: ttcn3-ggsn-test: add kernel test ...................................................................... Patch Set 3: (5 comments) https://gerrit.osmocom.org/c/docker-playground/+/23005/3/osmo-ggsn-latest/Dockerfile File osmo-ggsn-latest/Dockerfile: https://gerrit.osmocom.org/c/docker-playground/+/23005/3/osmo-ggsn-latest/Dockerfile@22 PS3, Line 22: RUN ln -s /bin/true /usr/local/bin/update-initramfs && \ Some description about this would be welcome https://gerrit.osmocom.org/c/docker-playground/+/23005/3/scripts/kernel-test/qemu-ifup.sh File scripts/kernel-test/qemu-ifup.sh: https://gerrit.osmocom.org/c/docker-playground/+/23005/3/scripts/kernel-test/qemu-ifup.sh@5 PS3, Line 5: echo "[host] qemu-ifup: $br, $1, $docker_if" maybe store $1 to some variable explaining the name instead of using $1 several times. https://gerrit.osmocom.org/c/docker-playground/+/23005/3/scripts/kernel-test/qemu-ifup.sh@11 PS3, Line 11: ethtool -K $br gro off gso off tso off tx off rx off sg off >/dev/null 2>&1 I don't think we need the ethtool lines here and below. https://gerrit.osmocom.org/c/docker-playground/+/23005/3/ttcn3-ggsn-test/initrd-ggsn.sh File ttcn3-ggsn-test/initrd-ggsn.sh: https://gerrit.osmocom.org/c/docker-playground/+/23005/3/ttcn3-ggsn-test/initrd-ggsn.sh@18 PS3, Line 18: Not sure what do we win by creating a separate initrd instead of simply sharing the docker rootfs inside the qemu env (security?), but fine. https://gerrit.osmocom.org/c/docker-playground/+/23005/3/ttcn3-ggsn-test/jenkins.sh File ttcn3-ggsn-test/jenkins.sh: https://gerrit.osmocom.org/c/docker-playground/+/23005/3/ttcn3-ggsn-test/jenkins.sh@24 PS3, Line 24: cp osmo-ggsn.cfg $VOL_BASE_DIR/ggsn/ This line can be moved to the else condition below. -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/23005 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I54e752048eed2a170a1cf4e0fd410de255b9de5d Gerrit-Change-Number: 23005 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-CC: laforge <[email protected]> Gerrit-Comment-Date: Mon, 22 Feb 2021 10:02:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
