fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/17283 )
Change subject: transport/pcsc: work around Python 3.5 bug: do not call disconnect() ...................................................................... Patch Set 3: (1 comment) https://gerrit.osmocom.org/c/pysim/+/17283/3/pySim/transport/pcsc.py File pySim/transport/pcsc.py: https://gerrit.osmocom.org/c/pysim/+/17283/3/pySim/transport/pcsc.py@43 PS3, Line 43: # self._con.disconnect() > What about simply except: here? And probably "pass" on the except if python > version is <=3.5. […] This sounds like a good option. I am wondering, do we really need this destructor? I guess self._con has its own destructor, and it would do the cleanup anyway... -- To view, visit https://gerrit.osmocom.org/c/pysim/+/17283 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I9c644bc5fe9791b141a30bfc13647d77937a82ee Gerrit-Change-Number: 17283 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <[email protected]> Gerrit-CC: pespin <[email protected]> Gerrit-Comment-Date: Mon, 01 Mar 2021 17:42:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <[email protected]> Gerrit-MessageType: comment
