fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/17283 )
Change subject: transport/pcsc: work around Python 3.5 bug: guard disconnect() ...................................................................... Patch Set 5: (1 comment) https://gerrit.osmocom.org/c/pysim/+/17283/4/pySim/transport/pcsc.py File pySim/transport/pcsc.py: https://gerrit.osmocom.org/c/pysim/+/17283/4/pySim/transport/pcsc.py@46 PS4, Line 46: pass > May be worth printing some message like "Omit disconnect() exception" This will break the unit tests that literally match everything printed. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/17283 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I9c644bc5fe9791b141a30bfc13647d77937a82ee Gerrit-Change-Number: 17283 Gerrit-PatchSet: 5 Gerrit-Owner: fixeria <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-Comment-Date: Wed, 03 Mar 2021 18:00:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <[email protected]> Gerrit-MessageType: comment
