fixeria has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/c/docker-playground/+/23303 )
Change subject: Make respawn.sh a common part of *-build/-obs images ...................................................................... Make respawn.sh a common part of *-build/-obs images Maintaining several versions of the same file in different folders is a bad idea, because at some point their content gets out of sync. This is exactly what happened to 'respawn.sh': sleep()ing was only implemented in 'osmo-bts-master/respawn.sh', other versions of this file would simply ignore '$SLEEP_BEFORE_RESPAWN'. The easiest solution would be to have all common files in a single directory, however Docker does not allow to ADD files from outside of the build context. In other words, all files must be in the same directory as the Dockerfile itself. At the same time, Docker allows the first argument of ADD to be a URL, and at least HTTP(S) is supported. Most of our images require the Internet connectivity anyway, so let's make it grab 'respawn.sh' from https://git.osmocom.org/docker-playground/. Change-Id: I3ec86c8610b3b43d39ea8e3da444861d317ced4e --- M centos8-build/Dockerfile M centos8-obs-latest/Dockerfile R common/respawn.sh M debian-buster-build/Dockerfile M debian-jessie-build/Dockerfile M debian-sid-build/Dockerfile M debian-stretch-obs-latest/Dockerfile M osmo-bts-latest/Dockerfile D osmo-bts-latest/respawn.sh M osmo-bts-master/Dockerfile M osmo-pcu-latest/Dockerfile D osmo-pcu-latest/respawn.sh M osmo-pcu-master/Dockerfile D osmo-pcu-master/respawn.sh 14 files changed, 18 insertions(+), 53 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/03/23303/2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/23303 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I3ec86c8610b3b43d39ea8e3da444861d317ced4e Gerrit-Change-Number: 23303 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <[email protected]> Gerrit-MessageType: newpatchset
