fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/23257 )
Change subject: bts-trx: Always submit rx PDTCH DATA.ind to l1sap ...................................................................... Patch Set 4: Code-Review+1 (1 comment) https://gerrit.osmocom.org/c/osmo-bts/+/23257/4/src/osmo-bts-trx/sched_lchan_pdtch.c File src/osmo-bts-trx/sched_lchan_pdtch.c: https://gerrit.osmocom.org/c/osmo-bts/+/23257/4/src/osmo-bts-trx/sched_lchan_pdtch.c@148 PS4, Line 148: presence_info I think you could just do: (rc > 0) ? PRES_INFO_BOTH : PRES_INFO_INVALID without the need to maintain a variable for that. This looks cleaner to me. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/23257 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I343c7a721dab72411edbca816c8864926bc329fb Gerrit-Change-Number: 23257 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <[email protected]> Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: osmith <[email protected]> Gerrit-Comment-Date: Thu, 11 Mar 2021 17:21:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
