pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/23309 )
Change subject: Replace PollController with newly added PDCH UL Controller ...................................................................... Patch Set 4: (1 comment) https://gerrit.osmocom.org/c/osmo-pcu/+/23309/4/tests/tbf/TbfTest.err File tests/tbf/TbfTest.err: https://gerrit.osmocom.org/c/osmo-pcu/+/23309/4/tests/tbf/TbfTest.err@3705 PS4, Line 3705: PDCH(bts=0,trx=0,ts=4) Expiring FN=112 but previous FN=13 is still reserved! > Is this expected? Yes, most of the unit tests are not 100% compatible with what a correct running system would do, but it's fine since usually they only seek testing one specific thing. Prior to my patches most of this issues were still there, but they weren't triggered because TIME.ind were not dispatched to PCU code by the test. -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/23309 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I683ca738ce5a133c49c36a1d94439a942d64a831 Gerrit-Change-Number: 23309 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Comment-Date: Fri, 12 Mar 2021 14:01:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <[email protected]> Gerrit-MessageType: comment
