pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/23492 )
Change subject: Track scheduled UL blocks through USF ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/c/osmo-pcu/+/23492/1/src/gprs_rlcmac_sched.cpp File src/gprs_rlcmac_sched.cpp: https://gerrit.osmocom.org/c/osmo-pcu/+/23492/1/src/gprs_rlcmac_sched.cpp@463 PS1, Line 463: poll_fn = rts_next_fn(fn, block_nr); > > So that means that whenever we request USF on FN = x, the PCU expects the > > response on FN = x + 1. […] Yes, I meant x+4 actually, or x+1 as in full blocks. Ok I get it now, I was indeed not thinking about the fact that each block is actually 4 frames (or 5 sometimes?) and hence of course the MS cannot answer until it fully received it, hence why the 4-5 FN offset. So that means the implementation is correct here, only my assumptions were confusing. Thanks for the explanation! -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/23492 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ia99c9edad6e5bd837e9baeb4fb2683b227887957 Gerrit-Change-Number: 23492 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <[email protected]> Gerrit-Reviewer: Hoernchen <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <[email protected]> Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: lynxis lazus <[email protected]> Gerrit-Comment-Date: Thu, 25 Mar 2021 11:43:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <[email protected]> Comment-In-Reply-To: pespin <[email protected]> Gerrit-MessageType: comment
