pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/23508 )
Change subject: stat_item: make value ids item specific ...................................................................... Patch Set 1: (3 comments) https://gerrit.osmocom.org/c/libosmocore/+/23508/1/src/stat_item.c File src/stat_item.c: https://gerrit.osmocom.org/c/libosmocore/+/23508/1/src/stat_item.c@279 PS1, Line 279: LOGP(DLSTATS, LOGL_DEBUG, "osmo_stat_item_discard_all is deprecated"); INFO? https://gerrit.osmocom.org/c/libosmocore/+/23508/1/src/stat_item.c@280 PS1, Line 280: return 0; You may want to call osmo_stats_discard_all() internally here? https://gerrit.osmocom.org/c/libosmocore/+/23508/1/src/stats.c File src/stats.c: https://gerrit.osmocom.org/c/libosmocore/+/23508/1/src/stats.c@715 PS1, Line 715: if (!have_value) { You can drop have_value (which is not an int anymore btw): if (osmo_stat_item_get_next(item, &item->stats_next_id, &value) <= 0) -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/23508 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ie65dcdf52c8fc3d916e20d7f0455f6223be6b64f Gerrit-Change-Number: 23508 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <[email protected]> Gerrit-Comment-Date: Mon, 29 Mar 2021 08:32:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
