laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/23538 )
Change subject: pySim-shell: automatic ADM pin from CSV-File ...................................................................... Patch Set 1: (3 comments) https://gerrit.osmocom.org/c/pysim/+/23538/1/pySim-shell.py File pySim-shell.py: https://gerrit.osmocom.org/c/pysim/+/23538/1/pySim-shell.py@372 PS1, Line 372: card_data_register(CardDataCsv(csv_default)) they might not be exclusive-or. You could register them in the order that the opts.csv is asked first, and as a fall-back the ~/.osmocom/... is used. https://gerrit.osmocom.org/c/pysim/+/23538/1/pySim/card_data.py File pySim/card_data.py: https://gerrit.osmocom.org/c/pysim/+/23538/1/pySim/card_data.py@33 PS1, Line 33: """abstract implementation of gst_data that only verifies the function parameters""" get_data https://gerrit.osmocom.org/c/pysim/+/23538/1/pySim/card_data.py@70 PS1, Line 70: if not cr: This way you open, read, parse and search the CSV file on every get(). Not sure if that was intentional. I would have loaded the file once int he constructor and then simply iterated through that in-memory representation. Not critical. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/23538 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I51835ccb16bcbce35e7f3765e8927a4451509e77 Gerrit-Change-Number: 23538 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <[email protected]> Gerrit-Comment-Date: Mon, 29 Mar 2021 20:46:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
