pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/23526 )
Change subject: tbf: Get rid of unneeded poll_scheduled() ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/c/osmo-pcu/+/23526/1/tests/tbf/TbfTest.err File tests/tbf/TbfTest.err: https://gerrit.osmocom.org/c/osmo-pcu/+/23526/1/tests/tbf/TbfTest.err@a418 PS1, Line 418: r > are those kind of changes of 'prip' expected? I don't immediately see how? That's due to the "if (poll-scheduled()) return false) being removed. That's removed because a TBF should actually be fine scheduling a control block even if a POLL is scheduled, since multiple POLL schedules should be possible concurrently. This check was there to prevent that happening since the whole implementation was not supporting that kind of thing. As a result, need_control_ts() may return now true in that situation, where it used to return false, hence increasing the priority of this tbf. -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/23526 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I875f51cade95faeb2d79dcebfead4c83e23a731b Gerrit-Change-Number: 23526 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <[email protected]> Gerrit-Comment-Date: Tue, 30 Mar 2021 15:05:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <[email protected]> Gerrit-MessageType: comment
