merlinchlosta has posted comments on this change. ( 
https://gerrit.osmocom.org/c/pysim/+/23483 )

Change subject: commands, ts_102_221: replace pytlv with uttlv
......................................................................


Patch Set 4:

I had a quick look here, especially trying to see if this will work for the 
SUCI_Calc_Info. What I didn't immediately get:

uttlv allows setting a map identifier<->name:
```
config = {0xa0: {'type': 'bytes', 'name': 'prot_scheme_id_list'},
                0xa1: {'type': 'TLV', 'name': 'hnet_pubkey_list'},
                0x80: {'type': 'bytes', 'name': 'hnet_pubkey_id'},
                0x81: {'type': 'bytes', 'name': 'hnet_pubkey'},}
FIX_TLV.set_tag_map(config)
```
Problem here: the nested TLVs won't be decoded with FIX_TLV but with type 'TLV' 
(hence, wrong length config).

The other thing: how would I encode an array of TLVs all with the same tag, and 
is the order preserved?
```
t = FIX_TLV()
t[0x80] = 123
t[0x80] = 321
```
This will of course just override the single 0x80 item.


--
To view, visit https://gerrit.osmocom.org/c/pysim/+/23483
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I971b818836aff2fbeb6769f819d496cee4bfa7cf
Gerrit-Change-Number: 23483
Gerrit-PatchSet: 4
Gerrit-Owner: dexter <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <[email protected]>
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Reviewer: merlinchlosta <[email protected]>
Gerrit-Comment-Date: Fri, 02 Apr 2021 08:42:51 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Reply via email to