fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/18617 )
Change subject: bts_osmobts: update the list of supported features ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/c/osmo-bsc/+/18617/1/src/osmo-bsc/bts_osmobts.c File src/osmo-bsc/bts_osmobts.c: https://gerrit.osmocom.org/c/osmo-bsc/+/18617/1/src/osmo-bsc/bts_osmobts.c@54 PS1, Line 54: osmo_bts_set_feature(&model->features, BTS_FEAT_OML_ALERTS); : osmo_bts_set_feature(&model->features, BTS_FEAT_CBCH); : osmo_bts_set_feature(&model->features, BTS_FEAT_SPEECH_F_V1); : osmo_bts_set_feature(&model->features, BTS_FEAT_SPEECH_H_V1); : osmo_bts_set_feature(&model->features, BTS_FEAT_SPEECH_F_EFR); : osmo_bts_set_feature(&model->features, BTS_FEAT_SPEECH_F_AMR); : osmo_bts_set_feature(&model->features, BTS_FEAT_SPEECH_H_AMR); : osmo_bts_set_feature(&model->features, BTS_FEAT_ETWS_PN); > how do you know that those are supported by the (remote, possibly old) > osmo-bts version? The point […] I think I am not understanding the point of having this list of 'expected' features in osmo-bsc. When I was working on this patch, I thought this is what we expect the recent osmo-bts to support. From your response, it now feels more like it's a set of features that any, even a very old osmo-bts version would support. We have EGPRS here, but not SPEECH_* features? Was EGPRS support introduced even earlier than FR/HR/AMR speech coding? I am confused. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/18617 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I431c8ab9478cbc40179903edc21043623d805da1 Gerrit-Change-Number: 18617 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <[email protected]> Gerrit-Comment-Date: Sun, 04 Apr 2021 17:33:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <[email protected]> Gerrit-MessageType: comment
