Patch Set 1: (1 comment)
https://gerrit.osmocom.org/#/c/4255/1/lib/ippool.c File lib/ippool.c: Line 218: dynsize = (1 << (addr.len*8 - addrprefixlen)); I always thought the "-1" is for the GGSN itself. So if you have a /24 with 256 addresses, one of the addresses is for the GGSN itself. Then you may also want to exclude the network, gateway and/or broadcast addresses in addition. However, the existing code would have mandated the GGSN to use the highest address within the pool to work. All of those assumptions are bad anyway. -- To view, visit https://gerrit.osmocom.org/4255 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I95c24bc690490155bec9e3933d678e4668d7745f Gerrit-PatchSet: 1 Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Owner: Pau Espin Pedrol <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-HasComments: Yes
