laforge has submitted this change. ( 
https://gerrit.osmocom.org/c/osmo-msc/+/17876 )

Change subject: SMS-over-GSUP: notify sender if no transaction found
......................................................................

SMS-over-GSUP: notify sender if no transaction found

Change-Id: I4f564610fadbfdbbc33de267786534a5405319f6
---
M src/libmsc/gsm_04_11_gsup.c
1 file changed, 2 insertions(+), 1 deletion(-)

Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved



diff --git a/src/libmsc/gsm_04_11_gsup.c b/src/libmsc/gsm_04_11_gsup.c
index 1f500d0..7a47e93 100644
--- a/src/libmsc/gsm_04_11_gsup.c
+++ b/src/libmsc/gsm_04_11_gsup.c
@@ -161,7 +161,8 @@
                LOGP(DLSMS, LOGL_NOTICE, "No transaction found for %s, "
                        "ignoring %s-%s message...\n", vlr_subscr_name(vsub),
                        msg_name, msg_is_err ? "Err" : "Res");
-               return -EIO; /* TODO: notify sender about that? */
+               gsup_client_mux_tx_error_reply(net->gcm, gsup_msg, 
GMM_CAUSE_NO_PDP_ACTIVATED);
+               return -EIO;
        }

        LOG_TRANS(trans, LOGL_DEBUG, "RX %s-%s\n", msg_name, msg_is_err ? "Err" 
: "Res");

--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/17876
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I4f564610fadbfdbbc33de267786534a5405319f6
Gerrit-Change-Number: 17876
Gerrit-PatchSet: 5
Gerrit-Owner: fixeria <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <[email protected]>
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-MessageType: merged

Reply via email to