fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/21118 )
Change subject: Configure E1 pcap file per line ...................................................................... Patch Set 8: Code-Review+1 (1 comment) https://gerrit.osmocom.org/c/libosmo-abis/+/21118/7/include/osmocom/abis/e1_input.h File include/osmocom/abis/e1_input.h: https://gerrit.osmocom.org/c/libosmo-abis/+/21118/7/include/osmocom/abis/e1_input.h@324 PS7, Line 324: e1_set_pcap_fd > What does it imply to deprecate the old symbol here? To add a deprecated > compliler warning? […] Indeed, I would add OSMO_DEPRECATED(...) like we usually do. Regardless where it's already used, it's still a good idea to do so. Imagine somebody would want to use this function in some other project some day. -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/21118 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I316c3d6a839e84c2f52a148c6b8dd6f5933cf4bf Gerrit-Change-Number: 21118 Gerrit-PatchSet: 8 Gerrit-Owner: keith <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Reviewer: keith <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-CC: laforge <[email protected]> Gerrit-Comment-Date: Wed, 14 Apr 2021 19:46:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: fixeria <[email protected]> Comment-In-Reply-To: keith <[email protected]> Gerrit-MessageType: comment
