Patch Set 1: (1 comment)
https://gerrit.osmocom.org/#/c/4291/1/lib/tun.h File lib/tun.h: Line 31: IP_TYPE_IPv6_GLOBAL = 4, naming is not exactly corect. there are link-local, node-locala and organization-local addresses, as well as global adresses. Your "global" basically means "anything not link-local", which is a different definition of that what IETF calls global adresses. -- To view, visit https://gerrit.osmocom.org/4291 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I277af191dc611b6bbcb83479f4ae338083740322 Gerrit-PatchSet: 1 Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Owner: Pau Espin Pedrol <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-HasComments: Yes
