fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/22766 )
Change subject: Make UTRAN encryption algorithms configurable ...................................................................... Patch Set 1: Code-Review+1 (1 comment) I am fine with the current approach. https://gerrit.osmocom.org/c/osmo-msc/+/22766/1/src/libmsc/msc_net_init.c File src/libmsc/msc_net_init.c: https://gerrit.osmocom.org/c/osmo-msc/+/22766/1/src/libmsc/msc_net_init.c@71 PS1, Line 71: net->uea_encryption_mask = (1 << 2) | (1 << 1); > Is uea_encryption_mask a mask of discrete bits or does it contain the > algorithm number? It's explained in the comment: /* bit-mask of permitted encryption algorithms. LSB=UEA0, MSB=UEA7 */ so: 0 is kind of meaningless 1 = (1 << 0) = UEA0 2 = (1 << 1) = UEA1 4 = (1 << 2) = UEA2 ... I am not sure if it really makes sense to make UEA0 part of the bit-mask, but at least this is consistent with the 'a5_encryption_mask' above. I hope this helps to understand better. -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/22766 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I91f9e50f9c1439aa19528f887b83ae9de628fcfd Gerrit-Change-Number: 22766 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <[email protected]> Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Reviewer: neels <[email protected]> Gerrit-CC: pespin <[email protected]> Gerrit-Comment-Date: Mon, 19 Apr 2021 14:30:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: dexter <[email protected]> Gerrit-MessageType: comment
