fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/23753 )
Change subject: SRVCC: Parse Last Used E-UTRAN PLMN Id in Handover Request ...................................................................... Patch Set 6: (1 comment) https://gerrit.osmocom.org/c/osmo-bsc/+/23753/6/src/osmo-bsc/handover_fsm.c File src/osmo-bsc/handover_fsm.c: https://gerrit.osmocom.org/c/osmo-bsc/+/23753/6/src/osmo-bsc/handover_fsm.c@439 PS6, Line 439: TLVP_VAL What if length of the value part is shorter than 3 bytes? I would use: TLVP_PRES_LEN(&tp, GSM0808_FE_IE_LAST_USED_EUTRAN_PLMN_ID, 3) -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/23753 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ia5008f11a4c36ef8085a2037d4abddd131086e6e Gerrit-Change-Number: 23753 Gerrit-PatchSet: 6 Gerrit-Owner: pespin <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <[email protected]> Gerrit-CC: laforge <[email protected]> Gerrit-Comment-Date: Mon, 19 Apr 2021 15:39:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
