Patch Set 2: (1 comment)
https://gerrit.osmocom.org/#/c/4273/2/src/hlr_vty_subscr.c File src/hlr_vty_subscr.c: Line 34: #define osmo_hexdump_buf(buf) osmo_hexdump_nospc((void*)buf, sizeof(buf)) > should rather not be named osmo_ ... maybe add to libosmocore? also going t what's tricky here is that it can only be used on a static buf[]. Having this in a library (header) file: What would happen if you use it on a "char *buf" ? I'm worried about adding public API that is too easy to get wrong. -- To view, visit https://gerrit.osmocom.org/4273 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I42b3b70a0439a8f2e4964d7cc31e593c1f0d7537 Gerrit-PatchSet: 2 Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Owner: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-HasComments: Yes
