dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/24131 )
Change subject: Add vty command 'show mgcp active' ...................................................................... Patch Set 2: Verified+1 Code-Review+1 (3 comments) Looks good to me. I wonder if show mgcp active [stats] makes sense, but apparently multiple optional non exclusive flags are not easy to model. https://gerrit.osmocom.org/c/osmo-mgw/+/24131/2/src/libosmo-mgcp/mgcp_vty.c File src/libosmo-mgcp/mgcp_vty.c: https://gerrit.osmocom.org/c/osmo-mgw/+/24131/2/src/libosmo-mgcp/mgcp_vty.c@324 PS2, Line 324: } maybe print something when no calls are active, otherwise the user only sees: Virtual trunk 0 with 30 endpoints: Virtual trunk 0 with 30 endpoints: No endpoints in use would look better. https://gerrit.osmocom.org/c/osmo-mgw/+/24131/2/src/libosmo-mgcp/mgcp_vty.c@355 PS2, Line 355: "Include Statistics\n") I think it should be "Include statistics" https://gerrit.osmocom.org/c/osmo-mgw/+/24131/2/src/libosmo-mgcp/mgcp_vty.c@365 PS2, Line 365: "Show only Endpoints with Active Connections\n") I am not an expert in spelling, but I think "Show only endpoints with active connections" is better. Just have a look at the style of the other help-strings in this file. -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/24131 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I23a26b4fdc03d8b2469d293dd6c06ed83ce739e9 Gerrit-Change-Number: 24131 Gerrit-PatchSet: 2 Gerrit-Owner: keith <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <[email protected]> Gerrit-Comment-Date: Wed, 05 May 2021 09:08:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
