Patch Set 1: Code-Review-1 (1 comment)
Please provide justification for both in commit message. https://gerrit.osmocom.org/#/c/4330/1/recipes-osmocom/osmo-sgsn/osmo-sgsn.inc File recipes-osmocom/osmo-sgsn/osmo-sgsn.inc: Line 6: DEPENDS = "c-ares libpcap libosmocore libosmo-netif libosmo-sccp osmo-ggsn" You not only add, you also remove. -- To view, visit https://gerrit.osmocom.org/4330 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I70f533bc18cab7883b076b532ef9656fb3f084f2 Gerrit-PatchSet: 1 Gerrit-Project: meta-telephony Gerrit-Branch: 201705 Gerrit-Owner: Pau Espin Pedrol <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Max <[email protected]> Gerrit-HasComments: Yes
