fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/24010 )
Change subject: utils: split string formatting from dec_addr_tlv ...................................................................... Patch Set 6: (1 comment) https://gerrit.osmocom.org/c/pysim/+/24010/6/pySim/cards.py File pySim/cards.py: https://gerrit.osmocom.org/c/pysim/+/24010/6/pySim/cards.py@392 PS6, Line 392: format_addr Does it really make sense to pass (None, None) to this function? -- To view, visit https://gerrit.osmocom.org/c/pysim/+/24010 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Id017b0786089adac4d6c5be688742eaa9699e529 Gerrit-Change-Number: 24010 Gerrit-PatchSet: 6 Gerrit-Owner: dexter <pma...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <lafo...@osmocom.org> Gerrit-Reviewer: pespin <pes...@sysmocom.de> Gerrit-CC: fixeria <vyanits...@sysmocom.de> Gerrit-Comment-Date: Thu, 06 May 2021 19:50:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
