Patch Set 2:
> That seems to be unnecessary complex. Placing symlinks into debian/
> means that both are installed automatically. This also means that
> the same package will work on all .deb with and without systemd.
> Adding ./configure options wouldn't mean we'll get read of manual
> install in OE - it just means that we'll shift it into .deb
> packaging.
Why do you want to have both installed automatically? you either use sysvinit
or systemd in your system, there's no sense in installing both.
Your distro either works with one or another, and so the package built comes
with one or the other.
Adding ./configure options + stuff in Makefile.am for sure means we get read of
manual install in OE, since we don't need to call "install
${S}/contrib/*.service ${D}/{systemd_system_unitdir}/" because make already
does that for us.
There's a good amount of projects installing systemd and OE does use that in
lots of places, "grep systemd | grep with" in poky shows for instance several
lines like this:
> meta/recipes-graphics/xorg-xserver/xserver-xorg.inc:141:PACKAGECONFIG[systemd]
> = "--with-systemd-daemon,--without-systemd-daemon,systemd"
> meta/recipes-extended/cups/cups.inc:32:PACKAGECONFIG[systemd] =
> "--with-systemd=${systemd_system_unitdir},--without-systemd,systemd"
> meta/recipes-extended/rpcbind/rpcbind_0.2.4.bb:40:PACKAGECONFIG[systemd] =
> "--with-systemdsystemunitdir=${systemd_unitdir}/system/, \
> meta/recipes-extended/rpcbind/rpcbind_0.2.4.bb:41:
> --without-systemdsystemunitdir, \
> meta/recipes-connectivity/avahi/avahi.inc:64:EXTRA_OECONF_SYSTEMD =
> "${@bb.utils.contains('DISTRO_FEATURES','systemd','--with-systemdsystemunitdir=${systemd_unitdir}/system/','--without-systemdsystemunitdir',d)}"
> meta/recipes-connectivity/neard/neard_0.16.bb:25:PACKAGECONFIG[systemd] =
> "--enable-systemd --with-systemdsystemunitdir=${systemd_unitdir}/system/
> --with-syste
mduserunitdir=${systemd_unitdir}/user/,--disable-systemd"
> meta/recipes-core/dbus/dbus_1.10.20.bb:108:PACKAGECONFIG[systemd] =
> "--enable-systemd
> --with-systemdsystemunitdir=${systemd_system_unitdir},--disable-systemd -
-without-systemdsystemunitdir,systemd"
--
To view, visit https://gerrit.osmocom.org/4315
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I392a90299489bc217a0a8cd8e4cf400cfe6b1bcf
Gerrit-PatchSet: 2
Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Owner: Max <[email protected]>
Gerrit-Reviewer: Harald Welte <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max <[email protected]>
Gerrit-Reviewer: Pau Espin Pedrol <[email protected]>
Gerrit-Reviewer: lynxis lazus <[email protected]>
Gerrit-HasComments: No
