pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/24179 )
Change subject: [VAMOS] Re-organize osmo-bts-trx specific structures ...................................................................... Patch Set 1: (2 comments) I would really welcome a better description regarding this commit: what is changed, and why, what are the rationales to do so. https://gerrit.osmocom.org/c/osmo-bts/+/24179/1/include/osmo-bts/gsm_data.h File include/osmo-bts/gsm_data.h: https://gerrit.osmocom.org/c/osmo-bts/+/24179/1/include/osmo-bts/gsm_data.h@459 PS1, Line 459: void *impl; model_data? model_priv? https://gerrit.osmocom.org/c/osmo-bts/+/24179/1/src/common/scheduler.c File src/common/scheduler.c: https://gerrit.osmocom.org/c/osmo-bts/+/24179/1/src/common/scheduler.c@612 PS1, Line 612: struct l1sched_ts *l1ts = ts->impl; isn't ts->impl always a struct l1sched_ts? why not using that struct instad of void* in the defintion of impl? -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/24179 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I7c4379e43a25e9d858d582a99bf6c4b65c9af481 Gerrit-Change-Number: 24179 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <[email protected]> Gerrit-Comment-Date: Mon, 10 May 2021 08:35:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
