fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/24224 )
Change subject: Optimize PAGING-CS PDCH set selection when target MS is known ...................................................................... Patch Set 1: (8 comments) https://gerrit.osmocom.org/c/osmo-pcu/+/24224/1/src/bts.cpp File src/bts.cpp: https://gerrit.osmocom.org/c/osmo-pcu/+/24224/1/src/bts.cpp@372 PS1, Line 372: /* We known the target MS for the paging req, send the req only on PDCH IMO, it would be a lot more readable if we had to separate functions for both cases: - when GprsMs is not NULL, and we know where to page; - when GprsMs is NULL, and we simply page everywhere. https://gerrit.osmocom.org/c/osmo-pcu/+/24224/1/src/bts.cpp@376 PS1, Line 376: 8 ARRAY_SIZE(ms->ul_tbf->pdch) https://gerrit.osmocom.org/c/osmo-pcu/+/24224/1/src/bts.cpp@387 PS1, Line 387: 8 ARRAY_SIZE(ms->dl_tbf->pdch) https://gerrit.osmocom.org/c/osmo-pcu/+/24224/1/src/bts.cpp@447 PS1, Line 447: LOGPDCH(&bts->trx[trx].pdch[ts], DRLCMAC, LOGL_INFO, "Paging on PACCH\n"); This looks more like a separate change to me, why doing it here? https://gerrit.osmocom.org/c/osmo-pcu/+/24224/1/src/gprs_bssgp_pcu.c File src/gprs_bssgp_pcu.c: https://gerrit.osmocom.org/c/osmo-pcu/+/24224/1/src/gprs_bssgp_pcu.c@183 PS1, Line 183: BSSGP_CAUSE_COND_IE_ERR BSSGP_CAUSE_MISSING_MAND_IE https://gerrit.osmocom.org/c/osmo-pcu/+/24224/1/src/gprs_bssgp_pcu.c@190 PS1, Line 190: BSSGP_CAUSE_COND_IE_ERR BSSGP_CAUSE_INV_MAND_INF https://gerrit.osmocom.org/c/osmo-pcu/+/24224/1/src/gprs_bssgp_pcu.c@211 PS1, Line 211: if (TLVP_PRESENT(tp, BSSGP_IE_TLLI)) Are we safe against an evil SGSN here? ;) https://gerrit.osmocom.org/c/osmo-pcu/+/24224/1/src/gprs_bssgp_pcu.c@230 PS1, Line 230: specific BTS How can you be sure that the MS is listening to a specific BTS? You only get notified when it enters another RAC, so what if the MS has switched to another BTS while you still have a GprsMs for it in the old BTS? -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/24224 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Iea46d5321a29d800813b1aa2bf4ce175ce45e2cf Gerrit-Change-Number: 24224 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <[email protected]> Gerrit-Reviewer: dexter <[email protected]> Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: neels <[email protected]> Gerrit-Comment-Date: Tue, 18 May 2021 20:00:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
