pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/24291 )
Change subject: kdf: add key derivation functions ...................................................................... Patch Set 5: (2 comments) This commit should definetly state from which repo + commit/release/version you imported all those kdf files from. https://gerrit.osmocom.org/c/libosmocore/+/24291/5/src/gsm/kdf.c File src/gsm/kdf.c: https://gerrit.osmocom.org/c/libosmocore/+/24291/5/src/gsm/kdf.c@33 PS5, Line 33: #define HMAC_FUN(k,lk,s,sl,out) gnutls_hmac_fast(GNUTLS_MAC_SHA256,k,lk,s,sl,out) I'd rename it to "HMAC_FUNC" https://gerrit.osmocom.org/c/libosmocore/+/24291/5/src/gsm/kdf/common.h File src/gsm/kdf/common.h: https://gerrit.osmocom.org/c/libosmocore/+/24291/5/src/gsm/kdf/common.h@2 PS5, Line 2: * wpa_supplicant/hostapd / common helper functions, etc. I guess we are fine with this? -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/24291 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ibf2e49edada944d91ceba62bd0d6b6ce69261fcd Gerrit-Change-Number: 24291 Gerrit-PatchSet: 5 Gerrit-Owner: Hoernchen <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <[email protected]> Gerrit-CC: pespin <[email protected]> Gerrit-Comment-Date: Thu, 20 May 2021 11:49:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
