Patch Set 1: Code-Review+2 (2 comments)
https://gerrit.osmocom.org/#/c/4372/1/src/socket.c File src/socket.c: Line 787: #endif /* HAVE_SYS_SOCKET_H */ you're adding socket related code outside of the ifdef, which breaks the eembedded build for OsmocomBB. Line 790: * \param[out] local_ip caller provided memory for resulting local IP-address might be good to explain what the size requirements of this is. -- To view, visit https://gerrit.osmocom.org/4372 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2988cc52b196fc8476703d1287e24cb4a48491c2 Gerrit-PatchSet: 1 Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Owner: dexter <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-HasComments: Yes
