Patch Set 2: > This means that you can do any updates you > like - add/remove files, change functions, etc. It all will just > become part of signed release commit.
One point is, I wouldn't want to mix releng changes in with functional changes made to the code, for the same reason that we don't want to mix in cosmetics... More importantly, dexter can't decide on his own that his change is good, hence he has to wait for code review and final merge before he can assume that tagging the patch's git hash is worth release-tagging. I can't push a signed tag for gerrit review, can I? Even if, in case the patch is tweaked, I'd have to readjust the tag every time. IIUC the only useful way is to merge first and then do release fu when it's in. The drawback is that we still have a commit with LIBVERSION 0:0:0 that is incompatible, before a release bumps it to 1:0:0. It's a bit of a dilemma. Maybe this patch should include the LIBVERSION bump, and making a semantic release with signed tag needs to happen after the merge? -- To view, visit https://gerrit.osmocom.org/4317 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifeb201d9006eec275a46708007ff342cdfc14e45 Gerrit-PatchSet: 2 Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Owner: dexter <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Max <[email protected]> Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-HasComments: No
