Patch Set 1: Code-Review-1 (3 comments)
(I don't like mixing in large comment tweaks with the actual release bumping) https://gerrit.osmocom.org/#/c/4318/1/debian/control File debian/control: Line 28: Conflicts: libosmonetif2, libosmonetif2 libosmonetif2 twice now? https://gerrit.osmocom.org/#/c/4318/1/src/Makefile.am File src/Makefile.am: Line 3: # before making any modifications: https://www.gnu.org/software/libtool/manual/html_node/Versioning.html like in osmo-mgw, this should rather say "please read TODO-RELEASE"? Line 4: LIBVERSION=4:0:1 add to the commit log that LIBVERSION got bumped, and why -- To view, visit https://gerrit.osmocom.org/4318 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifc8b9ca64edd40f96cea92388d0e2f000ee07a9d Gerrit-PatchSet: 1 Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Owner: Max <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Max <[email protected]> Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Pau Espin Pedrol <[email protected]> Gerrit-HasComments: Yes
