Patch Set 1: (1 comment)
https://gerrit.osmocom.org/#/c/4350/1/src/osmo-bsc/osmo_bsc_sigtran.c File src/osmo-bsc/osmo_bsc_sigtran.c: Line 344: conn_id, osmo_hexdump(msg->data, msg->len), osmo_sccp_addr_name(ss7, &msc->a.msc_addr)); > Why not use msgb_hexdump() instead? (if no lNh pointers are set, msgb_hexdump is basically a less optimal version of osmo_hexdump()) -- To view, visit https://gerrit.osmocom.org/4350 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibfe52a0b7dbca4c569c603a008d73d0d99d1c345 Gerrit-PatchSet: 1 Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Owner: dexter <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Max <[email protected]> Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-HasComments: Yes
