Patch Set 1: (1 comment)
I guess I'd just leave the existing get_value_string() calls as they are. purely cosmetic. For new patches I'd use the shorter function. https://gerrit.osmocom.org/#/c/4359/1/src/libbsc/bsc_vty.c File src/libbsc/bsc_vty.c: Line 139: abis_nm_admin_name(nms->administrative), I'm confused, didn't I just now see the same patch, only the old state printed a number? -- To view, visit https://gerrit.osmocom.org/4359 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2dccebef2f7fc745b845a49d723f5d89fc2baa41 Gerrit-PatchSet: 1 Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Owner: Pau Espin Pedrol <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-HasComments: Yes
