Patch Set 1: Code-Review-1 (2 comments)
https://gerrit.osmocom.org/#/c/4369/1//COMMIT_MSG Commit Message: Line 7: ifdef: fix conditional compiling I find the summary too general. Which conditional? what parts of the code? https://gerrit.osmocom.org/#/c/4369/1/src/gprs/gtphub_main.c File src/gprs/gtphub_main.c: Line 122: #endif I'm in two minds what to say now :) In the old VTY code, this would not do. We would have to change the node like osmo_ss7_vty_go_parent() does in its 'default:' case. Since the VTY indenting patch is merged, this will actually work, since the internal vty-go-parent semantics pop a node element from the stack instead of relying on the go_parent cb. Actually the best solution would be to not even register a go_parent_cb in the first place in case of !BUILD_IU -- To view, visit https://gerrit.osmocom.org/4369 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1c609ef0c344ce825c313335c7e084bf97159262 Gerrit-PatchSet: 1 Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Owner: dexter <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Max <[email protected]> Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: neels <[email protected]> Gerrit-HasComments: Yes
