Patch Set 3: > should this be accompanied by a bitvec_get_u64()?
I have not needed it so far, but feel free to follow-up with the patch if you feel like it. > Would it make sense to add such a flag in struct bitvec? Certainly not. The message can be a mix of 0/1/L/H. > '1LL' instead of cast? I think explicit cast is easier to read and it illustrates better what's the intention for this code. -- To view, visit https://gerrit.osmocom.org/4337 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1b670dacb55fb3063271d045f9faa10fccba10a6 Gerrit-PatchSet: 3 Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Owner: Max <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Max <[email protected]> Gerrit-Reviewer: Minh-Quang Nguyen <[email protected]> Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-HasComments: No
