Hoernchen has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/17024 )
Change subject: usb serial number descriptor ...................................................................... Patch Set 3: I am inclined to resubmit this without the ifdefs, at the time there was confusion because we had a old octsim branch and a master branch, and I was not really aware of the differences (octsim branch is old and unused) - the branch is tied to the samd/e series anyway so this should always work, and I am not aware (even now, a year later) of any attempts to regenerate the asf source for other projects targetting other chips while trying to reuse this bootloader. -- To view, visit https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/17024 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-asf4-dfu Gerrit-Branch: master Gerrit-Change-Id: I4a23682cee0849c788e5f6c611df4ed1f1cac3da Gerrit-Change-Number: 17024 Gerrit-PatchSet: 3 Gerrit-Owner: Hoernchen <[email protected]> Gerrit-Reviewer: Hoernchen <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: roh <[email protected]> Gerrit-CC: laforge <[email protected]> Gerrit-Comment-Date: Fri, 04 Jun 2021 17:41:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
