lynxis lazus has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmocore/+/23187 )

Change subject: gprs_ns2: implement local update weight procedure
......................................................................


Patch Set 6: Code-Review-2

(3 comments)

https://gerrit.osmocom.org/c/libosmocore/+/23187/5/src/gb/gprs_ns2_sns.c
File src/gb/gprs_ns2_sns.c:

https://gerrit.osmocom.org/c/libosmocore/+/23187/5/src/gb/gprs_ns2_sns.c@2209
PS5, Line 2209: /* Update SNS weights for a bind (local endpoint). */
> Update comment
Done


https://gerrit.osmocom.org/c/libosmocore/+/23187/5/src/gb/gprs_ns2_sns.c@2216
PS5, Line 2216:         /* TODO: ensure this bind is already added! */
> remove the TODO
Done


https://gerrit.osmocom.org/c/libosmocore/+/23187/5/src/gb/gprs_ns2_sns.c@2232
PS5, Line 2232:                 /* TODO: check if this bind is about to be 
added */
> remove the TODO
Done



--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/23187
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Icec4dabb46bc198f68f91bfe09ba279fbe68d454
Gerrit-Change-Number: 23187
Gerrit-PatchSet: 6
Gerrit-Owner: lynxis lazus <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <[email protected]>
Gerrit-Reviewer: lynxis lazus <[email protected]>
Gerrit-Reviewer: pespin <[email protected]>
Gerrit-CC: laforge <[email protected]>
Gerrit-Comment-Date: Sat, 05 Jun 2021 16:32:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: daniel <[email protected]>
Comment-In-Reply-To: lynxis lazus <[email protected]>
Gerrit-MessageType: comment

Reply via email to