Patch Set 3: Code-Review-1 I think the general issue is that people writing CSN.1 specified protocols always have to keep in mind that 1 != H and 0 != L, and no matter what we do here will not change that fact. Also, this is unrelated on whether bitvec_set_uint is used or not. Furthermore, one can very easily find all callers of bitvec_set_uint() by a simple 'git grep'.
-- To view, visit https://gerrit.osmocom.org/4338 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2fd8d17f9fa6c51ef51f4294882cca5944d71df2 Gerrit-PatchSet: 3 Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Owner: Max <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Max <[email protected]> Gerrit-Reviewer: Minh-Quang Nguyen <[email protected]> Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-HasComments: No
