lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/24586 )
Change subject: gprs_ns2_sns: add check for duplicates to add_ip6_elem() ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/c/libosmocore/+/24586/1/src/gb/gprs_ns2_sns.c File src/gb/gprs_ns2_sns.c: https://gerrit.osmocom.org/c/libosmocore/+/24586/1/src/gb/gprs_ns2_sns.c@510 PS1, Line 510: if (memcmp(&elems->ip6[i], ip6, sizeof(*ip6))) > I'm not sure we should rely on the fact that there is either no padding in > the elems struct, or that […] Ack -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/24586 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I4a1528ea3427946ce465085919b2b522d3cedd07 Gerrit-Change-Number: 24586 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-CC: laforge <[email protected]> Gerrit-Comment-Date: Sat, 12 Jun 2021 20:22:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <[email protected]> Gerrit-MessageType: comment
