Patch Set 1: (1 comment)
https://gerrit.osmocom.org/#/c/4340/1/include/osmocom/core/utils.h File include/osmocom/core/utils.h: Line 90: * \param[inout] dest char* to re-/allocate and append to. > Is comma missing? Shouldn't it be "in,out"? good catch. I actually thought it's "inout" and we most likely have other places in the code doing it wrong. -- To view, visit https://gerrit.osmocom.org/4340 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic9dba0e4a1eb5a7dc3cee2f181b9024ed4fc7005 Gerrit-PatchSet: 1 Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Owner: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Max <[email protected]> Gerrit-HasComments: Yes
