pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmocore/+/24784 )

Change subject: Rename osmo dyn ts enums to contain SDCCH8
......................................................................


Patch Set 1:

> Patch Set 1:
>
> is this safe? what about a BSC that thinks SDCCH8 is within that type of 
> dynamic channel, while the BTS version is older and only supports TCH + PDCH?

I first through about adding anew BTS_FEATURE to signal "SDCCH8 support in osmo 
dyn ts". BUt anyway, even if there's no such feature, in that case I'd expect 
Chan Activation to fail and hence the TS to return to PDCH, so not a big 
problem. I can write a test to verify that situation.


--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/24784
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I56dcfe4d17899630b17f80145c3ced72f1e91e68
Gerrit-Change-Number: 24784
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <[email protected]>
Gerrit-Comment-Date: Tue, 29 Jun 2021 09:03:07 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Reply via email to