pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/24513 )
Change subject: allow to configure multiple oml remote-ip addresses ...................................................................... Patch Set 6: (3 comments) https://gerrit.osmocom.org/c/osmo-bts/+/24513/5/src/common/abis.c File src/common/abis.c: https://gerrit.osmocom.org/c/osmo-bts/+/24513/5/src/common/abis.c@144 PS5, Line 144: /* In some implementations the user may specify a BSC host via commandline switch. If this is the case > This is related to osmo-bts-omldummy, this implementation has a commandline > switch to specify the BS […] Yes please, better do that. Create an entry for the llist in osmo-bts-omldummy specific code. https://gerrit.osmocom.org/c/osmo-bts/+/24513/6/src/common/abis.c File src/common/abis.c: https://gerrit.osmocom.org/c/osmo-bts/+/24513/6/src/common/abis.c@130 PS6, Line 130: osmo_fsm_inst_state_chg(fi, ABIS_LINK_ST_FAILED, 0, 0); maybe "ABIS_LINK_ST_CONN_DROPPED" would be more meaningful, since it's actually what happens when you are in that state. "FAILED" seems a bit too generic. https://gerrit.osmocom.org/c/osmo-bts/+/24513/6/src/common/abis.c@147 PS6, Line 147: if (!llist_contains(&bts->bsc_oml_hosts, priv->bsc_oml_host)) you are potentially accessing already freed memory here, since priv->bsc_oml_host is a pointer pointing to memory which may have been free by VTY. What you need to do is, in the VTY code, when removing the entry, change "priv->bsc_oml_host" to the next item in the list. The best may be actually sending an event to the FSM before freeing the memory: "dispatch(EV_OML_HOST_REMOVED, bsc_oml_host);" and update the llist internally in the FSM. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/24513 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I205f68a3a7f35fee4c38a7cfba2b014237df2727 Gerrit-Change-Number: 24513 Gerrit-PatchSet: 6 Gerrit-Owner: dexter <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <[email protected]> Gerrit-CC: fixeria <[email protected]> Gerrit-CC: pespin <[email protected]> Gerrit-Comment-Date: Tue, 29 Jun 2021 14:50:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <[email protected]> Comment-In-Reply-To: dexter <[email protected]> Gerrit-MessageType: comment
