neels has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/24797 )

Change subject: hodec2: fix low rxqual tch/h<->tch/f oscillation
......................................................................


Patch Set 3:

(1 comment)

https://gerrit.osmocom.org/c/osmo-bsc/+/24797/1/src/osmo-bsc/handover_decision_2.c
File src/osmo-bsc/handover_decision_2.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/24797/1/src/osmo-bsc/handover_decision_2.c@1194
PS1, Line 1194:         tch_f_with_low_rxqual = false;
> May be worth adding these as a separate helper API btw: 
> "tch_f_with_low_rxqual(lchan, rxlev_current) […]
look what you did! two new patches!
but the code looks much nicer now, thx



--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/24797
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I96cd5a494e661ba3bb0b6d22d25a9968d2a6813c
Gerrit-Change-Number: 24797
Gerrit-PatchSet: 3
Gerrit-Owner: neels <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <[email protected]>
Gerrit-Reviewer: pespin <[email protected]>
Gerrit-Comment-Date: Tue, 29 Jun 2021 20:25:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <[email protected]>
Gerrit-MessageType: comment

Reply via email to