fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/24776 )
Change subject: osmo-bts-trx: implement BCCH carrier power reduction mode ...................................................................... Patch Set 4: (1 comment) https://gerrit.osmocom.org/c/osmo-bts/+/24776/4/src/common/rsl.c File src/common/rsl.c: https://gerrit.osmocom.org/c/osmo-bts/+/24776/4/src/common/rsl.c@2217 PS4, Line 2217: if (c0->ts[7].bcch_power_red_db > 0) > It's 8 iterations after all, I'd prefer having a more readable code not > creating confusion tbh. Ok, my new approach that I wanted to submit is even more cumbersome. Nevermind. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/24776 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I3dcee6e910ccc61c5c63c728db9ea04327e2fc98 Gerrit-Change-Number: 24776 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <[email protected]> Gerrit-Comment-Date: Tue, 29 Jun 2021 21:19:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <[email protected]> Comment-In-Reply-To: fixeria <[email protected]> Gerrit-MessageType: comment
