pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/24785 )

Change subject: Rename osmo dyn ts enums to contain SDCCH8
......................................................................


Patch Set 3:

(1 comment)

https://gerrit.osmocom.org/c/osmo-bsc/+/24785/3/src/osmo-bsc/gsm_data.c
File src/osmo-bsc/gsm_data.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/24785/3/src/osmo-bsc/gsm_data.c@194
PS3, Line 194:  { GSM_PCHAN_OSMO_DYN, "TCH/F_TCH/H_SDCCH8_PDCH" },
I decided to keep previous formatting (adding SDCCH8) in what's used in VTY 
config, since I think it's more descriptive when looking/using the config. With 
one gasp you can find out kind of channels are there configured.

Feel free to provide feedback on whether you agree or not.



--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/24785
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Id5b89fe589a52ff88486435ac43809edb4b80f98
Gerrit-Change-Number: 24785
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Comment-Date: Wed, 30 Jun 2021 11:39:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Reply via email to