neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/16764 )
Change subject: db v6: determine 3G AUC IND from VLR name ...................................................................... Patch Set 13: (2 comments) https://gerrit.osmocom.org/c/osmo-hlr/+/16764/11/src/db_auc.c File src/db_auc.c: https://gerrit.osmocom.org/c/osmo-hlr/+/16764/11/src/db_auc.c@210 PS11, Line 210: auc_3g_ind &= (1U << aud3g.u.umts.ind_bitlen) - 1; modulo that the other comment mentions is here https://gerrit.osmocom.org/c/osmo-hlr/+/16764/11/src/db_hlr.c File src/db_hlr.c: https://gerrit.osmocom.org/c/osmo-hlr/+/16764/11/src/db_hlr.c@936 PS11, Line 936: sqlite3_column_int64 > I didn't see any change so far, or any statement claiming this is not a > problem. the IND value is allowed to be arbitrary, the very first step is a modulo by the IND-bitlen. Also the IND-bitlen may vary per subscriber, so it's not just a feature, there is no other way. We use this also to round robin a subscriber's IND-bits, assuming the IND value assigned to RAN peers (MSC,SGSN) is dealt out in increments of 1. In other words: totally fine if the value is completely random, expected to grow indefinitely. -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/16764 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: I6f0a6bbef3a27507605c3b4a0e1a89bdfd468374 Gerrit-Change-Number: 16764 Gerrit-PatchSet: 13 Gerrit-Owner: neels <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: osmith <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-Comment-Date: Tue, 13 Jul 2021 19:58:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <[email protected]> Gerrit-MessageType: comment
