neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/24980 )
Change subject: Split bts_vty.c creating bts_trx_vty.c ...................................................................... Patch Set 3: (2 comments) ok, but why? any functional reason? in osmo-bsc, i recently moved osmo_bsc_vty.c into bsc_vty.c to have less file splits and find DEFUNs easier. same as i still do with my two bicycle bags: i always looked in the first, didn't find it, then looked in the other, still didn't find it, to finally do find it in the first... https://gerrit.osmocom.org/c/osmo-bsc/+/24980/3/src/osmo-bsc/bts_trx_vty.c File src/osmo-bsc/bts_trx_vty.c: https://gerrit.osmocom.org/c/osmo-bsc/+/24980/3/src/osmo-bsc/bts_trx_vty.c@1 PS3, Line 1: /* OsmoBSC interface to quagga VTY, BTS node */ TRX node? https://gerrit.osmocom.org/c/osmo-bsc/+/24980/3/src/osmo-bsc/bts_trx_vty.c@2 PS3, Line 2: /* (C) 2009-2017 by Harald Welte <[email protected]> new date? -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/24980 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I15ec8f71a5d31915162cb3ad75ea77e934fa4887 Gerrit-Change-Number: 24980 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <[email protected]> Gerrit-Reviewer: Hoernchen <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <[email protected]> Gerrit-Reviewer: dexter <[email protected]> Gerrit-Reviewer: osmith <[email protected]> Gerrit-CC: neels <[email protected]> Gerrit-Comment-Date: Fri, 23 Jul 2021 02:00:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
