neels has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-msc/+/25076 )

Change subject: implement CM Re-Establish for voice calls
......................................................................


Patch Set 5:

(1 comment)

https://gerrit.osmocom.org/c/osmo-msc/+/25076/4/src/libmsc/gsm_04_08.c
File src/libmsc/gsm_04_08.c:

https://gerrit.osmocom.org/c/osmo-msc/+/25076/4/src/libmsc/gsm_04_08.c@921
PS4, Line 921:   * Clear any connections at will. */
> I guess fixing this requires major refactoring and is out of scope for this 
> patch. […]
i think when we receive GSUP for that IMSI during auth then it's a problem to 
have two msc_a for the same IMSI. Which one should get the response? send it to 
both would be an idea, then maybe we can overlap the two msc_a until after 
auth...?



--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/25076
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I6fa37d6ca9fcb1637742b40e37b68d67664c9b60
Gerrit-Change-Number: 25076
Gerrit-PatchSet: 5
Gerrit-Owner: neels <nhofm...@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pma...@sysmocom.de>
Gerrit-Reviewer: osmith <osm...@sysmocom.de>
Gerrit-Reviewer: pespin <pes...@sysmocom.de>
Gerrit-Comment-Date: Thu, 29 Jul 2021 20:56:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <osm...@sysmocom.de>
Gerrit-MessageType: comment

Reply via email to