lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/24650 )
Change subject: gprs_ns2_sns: free the NSE if the SIZE PDU is not valid ...................................................................... Patch Set 4: (1 comment) https://gerrit.osmocom.org/c/libosmocore/+/24650/2/src/gb/gprs_ns2_sns.c File src/gb/gprs_ns2_sns.c: https://gerrit.osmocom.org/c/libosmocore/+/24650/2/src/gb/gprs_ns2_sns.c@2254 PS2, Line 2254: sns_failed(fi, "Rx Size: Missing Enssential IE"); > I think in 3gpp speak this should be "Missing mandatory IE", but I don't know > that for sure. 48.016 says "Missing essential IE" in table 10.3.2.1. But you're right for other specs I know the "Missing mandatory IE". -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/24650 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ife889091ecba4180a90743deb786767008fe863d Gerrit-Change-Number: 24650 Gerrit-PatchSet: 4 Gerrit-Owner: lynxis lazus <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <[email protected]> Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: lynxis lazus <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-Comment-Date: Thu, 12 Aug 2021 02:14:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: dexter <[email protected]> Gerrit-MessageType: comment
