Patch Set 1: (1 comment)
> Even in that case I still think that we have to update tests as > well. scrap the "even in that case", otherwise I agree, could add some NULL tests. https://gerrit.osmocom.org/#/c/4407/1/src/utils.c File src/utils.c: Line 375: size_t ret = src ? strlen(src) : 0; > I guess it's a good idea to still zero-terminate 'dst' even if 'src' is NUL yes, NULL is semantically like "", and zero-termination is promised by the API, and it also is what we want. -- To view, visit https://gerrit.osmocom.org/4407 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ieba7ba262ace2e370a4b9a550b3131fb13f07413 Gerrit-PatchSet: 1 Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Owner: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Max <msur...@sysmocom.de> Gerrit-Reviewer: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-HasComments: Yes
