lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/24591 )
Change subject: gprs_ns2_sns: implement outbound SNS DEL procedures ...................................................................... Patch Set 9: (2 comments) My draft was still missing. https://gerrit.osmocom.org/c/libosmocore/+/24591/4/src/gb/gprs_ns2_sns.c File src/gb/gprs_ns2_sns.c: https://gerrit.osmocom.org/c/libosmocore/+/24591/4/src/gb/gprs_ns2_sns.c@2103 PS4, Line 2103: LOGPFSML(fi, LOGL_ERROR, "NSE %d: weight become invalid because of removing bind %s. Resetting the configuration\n", > Maybe "became", or "has become" is better? Done https://gerrit.osmocom.org/c/libosmocore/+/24591/4/src/gb/gprs_ns2_sns.c@2110 PS4, Line 2110: gprs_ns2_free_nsvc(nsvc); > Check if runtime NSVCs are still valid (sig_weight > 0) Good call. I'm looking into this. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/24591 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I53cd54dfd262c70c425c3f13dad3b29526daa523 Gerrit-Change-Number: 24591 Gerrit-PatchSet: 9 Gerrit-Owner: lynxis lazus <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <[email protected]> Gerrit-Reviewer: dexter <[email protected]> Gerrit-Reviewer: lynxis lazus <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-Comment-Date: Fri, 03 Sep 2021 19:58:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: daniel <[email protected]> Comment-In-Reply-To: dexter <[email protected]> Gerrit-MessageType: comment
